Messages in this thread | | | Date | Mon, 23 Mar 2009 09:44:42 +0900 | Subject | Re: [patch 3/3] mm: keep pages from unevictable mappings off the LRU lists | From | Minchan Kim <> |
| |
Hmm,,
This patch is another thing unlike previous series patches. Firstly, It looked good to me.
I think add_to_page_cache_lru have to become a fast path. But, how often would ramfs and shmem function be called ?
I have a concern for this patch to add another burden. so, we need any numbers for getting pros and cons.
Any thoughts ?
On Mon, Mar 23, 2009 at 5:13 AM, Johannes Weiner <hannes@cmpxchg.org> wrote: > Check if the mapping is evictable when initially adding page cache > pages to the LRU lists. If that is not the case, add them to the > unevictable list immediately instead of leaving it up to the reclaim > code to move them there. > > This is useful for ramfs and locked shmem which mark whole mappings as > unevictable and we know at fault time already that it is useless to > try reclaiming these pages. > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> > Cc: David Howells <dhowells@redhat.com> > Cc: Nick Piggin <npiggin@suse.de> > Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Cc: Rik van Riel <riel@redhat.com> > Cc: Peter Zijlstra <peterz@infradead.com> > Cc: MinChan Kim <minchan.kim@gmail.com> > Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com> > --- > mm/filemap.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 23acefe..8574530 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -506,7 +506,9 @@ int add_to_page_cache_lru(struct page *page, struct address_space *mapping, > > ret = add_to_page_cache(page, mapping, offset, gfp_mask); > if (ret == 0) { > - if (page_is_file_cache(page)) > + if (mapping_unevictable(mapping)) > + add_page_to_unevictable_list(page); > + else if (page_is_file_cache(page)) > lru_cache_add_file(page); > else > lru_cache_add_active_anon(page); > -- > 1.6.2.1.135.gde769 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >
-- Kinds regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |