[lkml]   [2009]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Subject[RFC][PATCH 0/2] Make radeonfb use PCI PM core for suspendig device (was: Re: [RFC][PATCH] PCI PM: Be extra careful when changing power states of devices)
    On Saturday 21 March 2009, Rafael J. Wysocki wrote:
    > From: Rafael J. Wysocki <>
    > The story in shows
    > that setting the power state of a PCI device by
    > pci_raw_set_power_state() may sometimes fail. For this reason,
    > pci_raw_set_power_state() should not assume that the power state of
    > the device has actually changed after writing into its PMCSR.
    > Instead, it should read the value from there and use it to update
    > dev->current_state. It also is useful to print a warning if the
    > device's power state hasn't changed as expected.
    > Signed-off-by: Rafael J. Wysocki <>
    > ---
    OK, since the Ben's radeonfb fix for bug #12846 has been merged, I'd like
    to do something a bit different.

    Patch 1/2 introduces __pci_set_power_state() that will allow the radeonfb
    driver not to open code PCI PM operations.

    Patch 2/2 makes the driver use __pci_set_power_state().

    Comments welcome.


     \ /
      Last update: 2009-03-22 22:17    [W:0.021 / U:1.944 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site