lkml.org 
[lkml]   [2009]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] x86: e820.h fix various signedness issues in setup.c and e820.c
On Mon, Mar 23, 2009 at 12:53:51AM +0530, Jaswinder Singh Rajput wrote:
>
> From: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> Date: Mon, 23 Mar 2009 00:27:11 +0530
> Subject: [PATCH] x86: e820.h fix various signedness issues in setup.c and e820.c
>
> Impact: cleanup
>
> This fixed various signedness issues in setup.c and e820.c:
> arch/x86/kernel/setup.c:455:53: warning: incorrect type in argument 3 (different signedness)
> arch/x86/kernel/setup.c:455:53: expected int *pnr_map
> arch/x86/kernel/setup.c:455:53: got unsigned int extern [toplevel] *<noident>
> arch/x86/kernel/setup.c:639:53: warning: incorrect type in argument 3 (different signedness)
> arch/x86/kernel/setup.c:639:53: expected int *pnr_map
> arch/x86/kernel/setup.c:639:53: got unsigned int extern [toplevel] *<noident>
> arch/x86/kernel/setup.c:820:54: warning: incorrect type in argument 3 (different signedness)
> arch/x86/kernel/setup.c:820:54: expected int *pnr_map
> arch/x86/kernel/setup.c:820:54: got unsigned int extern [toplevel] *<noident>
>
> arch/x86/kernel/e820.c:670:53: warning: incorrect type in argument 3 (different signedness)
> arch/x86/kernel/e820.c:670:53: expected int *pnr_map
> arch/x86/kernel/e820.c:670:53: got unsigned int [toplevel] *<noident>
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> arch/x86/include/asm/e820.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/include/asm/e820.h b/arch/x86/include/asm/e820.h
> index 00d41ce..a1e1c54 100644
> --- a/arch/x86/include/asm/e820.h
> +++ b/arch/x86/include/asm/e820.h
> @@ -57,7 +57,7 @@ struct e820entry {
> } __attribute__((packed));
>
> struct e820map {
> - __u32 nr_map;
> + int nr_map;
> struct e820entry map[E820_X_MAX];
> };

but that header is exported so use of plain int looks wrong.

Sam


\
 
 \ /
  Last update: 2009-03-22 21:09    [W:0.064 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site