lkml.org 
[lkml]   [2009]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] x86: apic/io_apic fix compilation warning

* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

> Hello Ingo,
>
> Is this fix looks OK to you:
>
> From: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> Date: Sat, 21 Mar 2009 15:41:17 +0530
> Subject: [PATCH] x86: apic/io_apic fix compilation warning
>
> Fix:
> arch/x86/kernel/apic/io_apic.c:1431: warning: ‘msi_ir_chip’ defined but not used
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> arch/x86/kernel/apic/io_apic.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index d882c03..3ca7838 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -1428,7 +1428,6 @@ void __setup_vector_irq(int cpu)
>
> static struct irq_chip ioapic_chip;
> static struct irq_chip ir_ioapic_chip;
> -static struct irq_chip msi_ir_chip;
>
> #define IOAPIC_AUTO -1
> #define IOAPIC_EDGE 0
> @@ -3402,6 +3401,8 @@ static struct irq_chip msi_ir_chip = {
> #endif
> .retrigger = ioapic_retrigger_irq,
> };
> +#else
> +static struct irq_chip msi_ir_chip;
> #endif

hm, i think it would be cleaner to remove the CONFIG_INTR_REMAP
define altogether and define msi_ir_chip all the time. (and make
sure this build fine even in the !INTR_REMAP case)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-03-21 17:39    [W:0.044 / U:1.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site