lkml.org 
[lkml]   [2009]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] perfcounters: record time running and time enabled for each counter

* Andrew Morton <akpm@linux-foundation.org> wrote:

> > + u64 time_enabled;
> > + u64 time_running;
>
> These look like times. I see no indication (here) as to the units.
>
> > + u64 start_enabled;
>
> This looks like a boolean, but it's u64.
>
> > + u64 start_running;
>
> hard to say.
>
> > + u64 last_stopped;
>
> probably a time, unknown units.
>
>
> Perhaps one of the reasons why this code is confusing is the
> blurring between the "time" at which an event occured and the
> "time" between the occurrence of two events. A weakness in
> English, I guess. Using the term "interval" in the latter case
> will help a lot.

What we use in the scheduler is "sum_time" or "runtime". A bit of a
tongue twister but unambiguous.

Ingo


\
 
 \ /
  Last update: 2009-03-21 16:55    [W:0.069 / U:1.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site