lkml.org 
[lkml]   [2009]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] trace/ring_buffer: fix section mismatch warning

* Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> With linux-next I get this:
>
> Section mismatch in reference from the function
> ring_buffer_alloc() to the function .cpuinit.text:rb_cpu_notify()
> The function ring_buffer_alloc() references the function __cpuinit
> rb_cpu_notify(). This is often because ring_buffer_alloc lacks a
> __cpuinit annotation or the annotation of rb_cpu_notify is wrong.
>
> This is a false positive since rb_cpu_notify gets only referenced
> if CONFIG_HOTPLUG_CPU=y. To get rid of the warning annotate
> ring_buffer_alloc with __ref.
>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> kernel/trace/ring_buffer.c | 2 +-

Frederic has beaten you to it narrowly:

09c9e84: tracing/ring-buffer: don't annotate rb_cpu_notify with __cpuinit

:)

Ingo


\
 
 \ /
  Last update: 2009-03-21 15:41    [W:0.060 / U:3.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site