lkml.org 
[lkml]   [2009]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/25] Move check for disabled anti-fragmentation out of fastpath
    Date
    On low-memory systems, anti-fragmentation gets disabled as there is nothing
    it can do and it would just incur overhead shuffling pages between lists
    constantly. Currently the check is made in the free page fast path for every
    page. This patch moves it to a slow path. On machines with low memory,
    there will be small amount of additional overhead as pages get shuffled
    between lists but it should quickly settle.

    Signed-off-by: Mel Gorman <mel@csn.ul.ie>
    Reviewed-by: Christoph Lameter <cl@linux-foundation.org>
    ---
    include/linux/mmzone.h | 3 ---
    mm/page_alloc.c | 4 ++++
    2 files changed, 4 insertions(+), 3 deletions(-)

    diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
    index 1aca6ce..ca000b8 100644
    --- a/include/linux/mmzone.h
    +++ b/include/linux/mmzone.h
    @@ -50,9 +50,6 @@ extern int page_group_by_mobility_disabled;

    static inline int get_pageblock_migratetype(struct page *page)
    {
    - if (unlikely(page_group_by_mobility_disabled))
    - return MIGRATE_UNMOVABLE;
    -
    return get_pageblock_flags_group(page, PB_migrate, PB_migrate_end);
    }

    diff --git a/mm/page_alloc.c b/mm/page_alloc.c
    index 7ba7705..d815c8f 100644
    --- a/mm/page_alloc.c
    +++ b/mm/page_alloc.c
    @@ -171,6 +171,10 @@ int page_group_by_mobility_disabled __read_mostly;

    static void set_pageblock_migratetype(struct page *page, int migratetype)
    {
    +
    + if (unlikely(page_group_by_mobility_disabled))
    + migratetype = MIGRATE_UNMOVABLE;
    +
    set_pageblock_flags_group(page, (unsigned long)migratetype,
    PB_migrate, PB_migrate_end);
    }
    --
    1.5.6.5


    \
     
     \ /
      Last update: 2009-03-20 11:09    [W:0.021 / U:208.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site