lkml.org 
[lkml]   [2009]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 12/43] NFSD: provide encode routine for OP_OPENATTR
    2.6.28-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Benny Halevy <bhalevy@panasas.com>

    commit 84f09f46b4ee9e4e9b6381f8af31817516d2091b upstream.

    Although this operation is unsupported by our implementation
    we still need to provide an encode routine for it to
    merely encode its (error) status back in the compound reply.

    Thanks for Bill Baker at sun.com for testing with the Sun
    OpenSolaris' client, finding, and reporting this bug at
    Connectathon 2009.

    This bug was introduced in 2.6.27

    Signed-off-by: Benny Halevy <bhalevy@panasas.com>
    Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/nfsd/nfs4xdr.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/nfsd/nfs4xdr.c
    +++ b/fs/nfsd/nfs4xdr.c
    @@ -2598,6 +2598,7 @@ static nfsd4_enc nfsd4_enc_ops[] = {
    [OP_LOOKUPP] = (nfsd4_enc)nfsd4_encode_noop,
    [OP_NVERIFY] = (nfsd4_enc)nfsd4_encode_noop,
    [OP_OPEN] = (nfsd4_enc)nfsd4_encode_open,
    + [OP_OPENATTR] = (nfsd4_enc)nfsd4_encode_noop,
    [OP_OPEN_CONFIRM] = (nfsd4_enc)nfsd4_encode_open_confirm,
    [OP_OPEN_DOWNGRADE] = (nfsd4_enc)nfsd4_encode_open_downgrade,
    [OP_PUTFH] = (nfsd4_enc)nfsd4_encode_noop,



    \
     
     \ /
      Last update: 2009-03-21 00:55    [W:0.021 / U:0.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site