lkml.org 
[lkml]   [2009]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 09/32] ALSA: pcm_oss, fix locking typo
    2.6.27-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Jiri Slaby <jirislaby@gmail.com>

    commit 91054598f794fb5d8a0b1e747ff8e2e8fc2115b3 upstream.

    s/mutex_lock/mutex_unlock/ on 2 fail paths in snd_pcm_oss_proc_write.
    Probably a typo, lock should be unlocked when leaving the function.

    Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    sound/core/oss/pcm_oss.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/sound/core/oss/pcm_oss.c
    +++ b/sound/core/oss/pcm_oss.c
    @@ -2854,7 +2854,7 @@ static void snd_pcm_oss_proc_write(struc
    setup = kmalloc(sizeof(*setup), GFP_KERNEL);
    if (! setup) {
    buffer->error = -ENOMEM;
    - mutex_lock(&pstr->oss.setup_mutex);
    + mutex_unlock(&pstr->oss.setup_mutex);
    return;
    }
    if (pstr->oss.setup_list == NULL)
    @@ -2868,7 +2868,7 @@ static void snd_pcm_oss_proc_write(struc
    if (! template.task_name) {
    kfree(setup);
    buffer->error = -ENOMEM;
    - mutex_lock(&pstr->oss.setup_mutex);
    + mutex_unlock(&pstr->oss.setup_mutex);
    return;
    }
    }



    \
     
     \ /
      Last update: 2009-03-21 00:21    [W:4.162 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site