Messages in this thread | | | Date | Fri, 20 Mar 2009 15:29:21 +0000 | From | Mel Gorman <> | Subject | Re: [PATCH 08/25] Calculate the preferred zone for allocation only once |
| |
On Fri, Mar 20, 2009 at 11:06:46AM -0400, Christoph Lameter wrote: > On Fri, 20 Mar 2009, Mel Gorman wrote: > > > get_page_from_freelist() can be called multiple times for an allocation. > > Part of this calculates the preferred_zone which is the first usable > > zone in the zonelist. This patch calculates preferred_zone once. > > Isnt this adding an additional pass over the zonelist? Maybe mitigaged by > the first zone usually being the preferred zone. >
The alternative is uglifing the iterator quite a bit and making the code a bit impeneratable. The walk to the first preferred zone should be very short.
-- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab
| |