Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [RFC][PATCH 2/4] PM: Change suspend code ordering | Date | Mon, 2 Mar 2009 23:02:39 +0100 |
| |
On Monday 02 March 2009, Linus Torvalds wrote: > > On Sun, 1 Mar 2009, Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki <rjw@sisk.pl> > > > > Change the ordering of the suspend core code so that the platform > > "prepare" callback is executed and the nonboot CPUs are disabled > > after calling device drivers' "late suspend" methods. > > Ok, ack on this whole series, looks fine.
Thanks!
> I'd like to see a 5/4 though: > > > This change will allow us to rework the PCI PM core so that the power > > state of devices is changed in the "late" phase of suspend (and > > analogously in the "early" phase of resume) > > .. doing this. Right now we have that hacky "avoid ACPI by doing a special > limited form of pci_set_power_state() and pci_enable() in the > early_resume. I'd love to see the actual PCI code cleanup too.
Sure, that's the next step, but I wanted to get the ack on the preliminary patches first. :-)
Rafael
| |