lkml.org 
[lkml]   [2009]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch 2.6.29-rc6+misc] MMC: regulator utilities
Date
On Monday 02 March 2009, Pierre Ossman wrote:
> > > > +int mmc_regulator_set_ocr(struct mmc_host *host, struct regulator *supply)
> > > > +{
> > >
> > > Why not pass the vdd directly? Saves a few dereferences if nothing else.
> >
> > This call syntax is simpler, which is usually a win.
> > Passing a third parameter would create fault paths
> > of the "pass *wrong* parameter" flavor.
> >
> > In terms of object code, when I've looked at such things
> > the dereferences generally cost the same as a ref to a
> > parameter, but passing an extra parameter isn't free.
> >
>
> I couldn't see host being used in there, so I was thinking more of a
> replacement, not an addition.

Oh, I see. That'd make sense. Just pass host->ios.vdd.





\
 
 \ /
  Last update: 2009-03-02 23:03    [W:0.132 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site