Messages in this thread | | | Date | Mon, 2 Mar 2009 20:42:39 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH] crypto: fix handling of sg buffers in ixp4xx driver |
| |
On Mon, Mar 02, 2009 at 12:45:12PM +0100, Christian Hohnstaedt wrote: > > - keep dma functions away from chained scatterlists. > Use the existing scatterlist iteration inside the driver > to call dma_map_single() for each chunk and avoid dma_map_sg().
Hmm, interesting. So crypto has its own scatterlist chaining stuff which is different and incompatible from what is supported by the rest of the kernel.
That's really confusing. There's know way to know whether a struct scatterlist should be walked by using the scatterwalk_* stuff or the generic stuff. Excellent for reviewing.
So, sorry, I'm not qualified to review this. Please find someone else who knows about crypto stuff.
| |