Messages in this thread | | | Subject | Re: Microblaze linux support | From | Jaswinder Singh Rajput <> | Date | Thu, 19 Mar 2009 16:17:46 +0530 |
| |
On Thu, 2009-03-19 at 11:26 +0100, Michal Simek wrote:
> you are welcome - I can quickly test and add all changes to git. > > Is it good style separate extern definition and EXPORT_SYMBOL? > > I have three choices? > 1. keep extern + EXPORT_SYMBOL below - current style > 2. move only extern to header file > 3. move extern and EXPORT_SYMBOL to header. > > What is preferable way?
externs should be in header files
EXPORT_SYMBOL should immediately follow its function/variable should normally be in source files like : arch/x86/kernel/process.c and if required can also be defined in header files like: arch/x86/include/asm/percpu.h
-- JSR
| |