Messages in this thread | | | Date | Thu, 19 Mar 2009 09:23:28 +0100 | From | Ingo Molnar <> | Subject | Re: [git-pull -tip] x86: mpparse cleanup |
| |
* Thomas Gleixner <tglx@linutronix.de> wrote:
> On Thu, 19 Mar 2009, Jaswinder Singh Rajput wrote: > > > > > > > > As I told you earlier, I cannot check this on my side. Only > > > > suspect will be check_irq_src() please test this patch if this > > > > does not work I will revert check_irq_src(): > > > > > > no need to test on your side. If a patch is broken the first step is > > > to take a look at the patch and think about it. For example this > > > block: > > > > > > > Subject: [PATCH] x86: mpparse introduced few helper functions > > > > Introduced helper functions: > > skip_entry, smp_reserve_bootmem, check_irq_src and check_slot > > And to make review and testing simpler can we please have separate > patches for those helper functions as far as it is possible.
yes - that's definitely a good idea for the future. I'll give the fix another chance in testing - if it fails again we have to risk-reduce by doing more splitups.
Ingo
| |