lkml.org 
[lkml]   [2009]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: Tree for March 19 (wireless/p54)
Michael Buesch wrote:
> On Thursday 19 March 2009 18:28:30 Randy Dunlap wrote:
>> Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20090318:
>>
>> ERROR: "led_classdev_register" [drivers/net/wireless/p54/p54common.ko] undefined!
>> ERROR: "led_classdev_unregister" [drivers/net/wireless/p54/p54common.ko] undefined!
>>
>> One possible option (fix) is to have CONFIG_MAC80211_LEDS also select
>> LEDS_CLASS (that would build the missing functions).
>
> Does p54 select CONFIG_MAC80211_LEDS? If that's the case, I think it should

No, it doesn't. p54common.c just has a large block of code that is
surrounded by
#ifdef CONFIG_MAC80211_LEDS
...
#endif

so we could argue that it's just purely a p54 bug.

> probably do it the other way around. p54 should build its LED code if CONFIG_MAC80211_LEDS
> is available. Otherwise it should not.
>
> This way you don't enter the SELECT dependency hell and still have automagic configuration.
>
> Take a look at b43 for an example.


--
~Randy


\
 
 \ /
  Last update: 2009-03-19 19:51    [W:0.123 / U:0.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site