Messages in this thread | | | Date | Thu, 19 Mar 2009 12:09:12 -0600 | From | Matthew Wilcox <> | Subject | Re: [PATCH v4 06/12] PCI: Introduce pci_rescan_bus() |
| |
On Thu, Mar 19, 2009 at 11:49:38AM -0600, Alex Chiang wrote: > I went over and ran it on all my patches, and that was indeed one > of the complaints. > > But when it comes to file consistency vs "letter of the law" I > like to keep things consistent (even if broken) in the file. > > I could go back and move all those EXPORT_SYMBOL declarations to > the "proper" place. Is that too much noise though?
The accepted way to do this is to add a prep patch which just fixes the checkpatch warnings (ie moves the EXPORT_SYMBOLs). Then your patch is all shiny and fresh.
-- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
| |