lkml.org 
[lkml]   [2009]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: oops in tracepoint_update_probe_range()
* Ingo Molnar (mingo@elte.hu) wrote:
>
> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > On Thu, 19 Mar 2009, Mathieu Desnoyers wrote:
> > >
> > > Jaswinder : maybe you have old modules in your /lib/modules/`uname -r`
> > > directory which have the correct version, but the wrong module.h header ?
> >
> > Isn't there a module versioning that prevents such things?
>
> It can be overriden. In any case, the NULL check we have there now
> makes sense.
>
> Ingo

Well, it duplicates the check for begin == end. Actually, if begin !=
end _and_ being is NULL, this should be a WARN_ON or BUG_ON, because
the kernel would be trying to load a module with incompatible struct
module.

Are we supposed to assume that module.c allows loading modules with
incompatible struct module at all ? That sounds like we would be trying
to fix up things broken by the module loader in the first place.

Mathieu


--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68


\
 
 \ /
  Last update: 2009-03-19 17:03    [W:0.181 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site