Messages in this thread | | | From | hooanon05@yahoo ... | Subject | Re: Q: NFSD readdir in linux-2.6.28 | Date | Fri, 20 Mar 2009 00:34:50 +0900 |
| |
David Woodhouse: > Yes, well spotted. It didn't matter when the buffered readdir() was > purely internal to XFS, because it didn't matter there that we called > ->lookup() without i_mutex set. But now we're exposing arbitrary file > systems to it, we need to make sure we follow the locking rules. > > I _think_ it's sufficient to make the affected callers of > lookup_one_len() lock the parent's i_mutex for themselves before calling > it. I'll take a closer look...
If you remember why you discarded the FS_NO_LOOKUP_IN_READDIR flag approach, please let me know. URL or something is enough.
Thanx J. R. Okajima
| |