lkml.org 
[lkml]   [2009]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Microblaze linux support
Jaswinder Singh Rajput wrote:
> On Thu, 2009-03-19 at 11:26 +0100, Michal Simek wrote:
>
>> you are welcome - I can quickly test and add all changes to git.
>>
>> Is it good style separate extern definition and EXPORT_SYMBOL?
>>
>> I have three choices?
>> 1. keep extern + EXPORT_SYMBOL below - current style
>> 2. move only extern to header file
>> 3. move extern and EXPORT_SYMBOL to header.
>>
>> What is preferable way?
>
> externs should be in header files
>
> EXPORT_SYMBOL should immediately follow its function/variable should
> normally be in source files like : arch/x86/kernel/process.c

Yes, I know -> is should be in all microblaze code (for example
arch/microblaze/lib folder)


> and if required can also be defined in header files like:
> arch/x86/include/asm/percpu.h

As wrote Ingo this is a little bit different case.

Thanks for you comments,
Michal
>
> --
> JSR
>


--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854


\
 
 \ /
  Last update: 2009-03-19 12:15    [W:0.146 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site