Messages in this thread | | | Date | Wed, 18 Mar 2009 15:08:33 +0000 | From | Mel Gorman <> | Subject | Re: [PATCH 20/35] Use a pre-calculated value for num_online_nodes() |
| |
On Mon, Mar 16, 2009 at 12:47:35PM -0400, Christoph Lameter wrote: > On Mon, 16 Mar 2009, Mel Gorman wrote: > > > On Mon, Mar 16, 2009 at 12:08:25PM -0400, Christoph Lameter wrote: > > > On Mon, 16 Mar 2009, Mel Gorman wrote: > > > > > > > +extern int static_num_online_nodes; > > > > > > Strange name. Could we name this nr_online_nodes or so? > > > > > > > It's to match the function name. Arguably I could also have replaced the > > implementation of num_online_nodes() with a version that uses the static > > variable. > > We have nr_node_ids etc. It would be consistant with that naming. >
Naming has never been great, but in this case the static value is a direct replacement of num_online_nodes(). I think having a similarly-named-but-still-different name obscures more than it helps.
-- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab
| |