Messages in this thread Patch in this message | | | From | swhiteho@redhat ... | Subject | [PATCH 07/18] GFS2: Fix error path ref counting for root inode | Date | Wed, 18 Mar 2009 12:23:42 +0000 |
| |
From: Steven Whitehouse <swhiteho@redhat.com>
We were keeping hold of an extra ref to the root inode in one of the error paths, that resulted in a hang.
Reported-by: Nate Straz <nstraz@redhat.com> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com> Tested-by: Robert Peterson <rpeterso@redhat.com>
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index 95bb33e..e502b37 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -1258,6 +1258,8 @@ fail_sb: dput(sdp->sd_root_dir); if (sdp->sd_master_dir) dput(sdp->sd_master_dir); + if (sb->s_root) + dput(sb->s_root); sb->s_root = NULL; fail_locking: init_locking(sdp, &mount_gh, UNDO); -- 1.6.0.3
| |