Messages in this thread | | | From | "Sosnowski, Maciej" <> | Date | Wed, 18 Mar 2009 12:09:52 +0000 | Subject | RE: [PATCH] dmaengine: Add Kconfig of DMA data align for DMA Test driver |
| |
Dan Williams wrote: > On Wed, Mar 11, 2009 at 11:30 PM, Nobuhiro Iwamatsu > <iwamatsu.nobuhiro@renesas.com> wrote: >> Test drivers of DMA engine usually perform DMA transfer by 1 byte >> unit. This can set transfer size of DMA and aligns data for tests. >> >> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com> >> Cc: Haavard Skinnemoen <hskinnemoen@atmel.com> >> Cc: Maciej Sosnowski <maciej.sosnowski@intel.com> >> Cc: Dan Williams <dan.j.williams@intel.com> >> --- > > This should just be a module parameter, and it needs error handling > for the alignment > transfer length case. > > Thanks, > Dan
I agree with Dan. Align size should be rather module parameter.
Regards, Maciej
| |