Messages in this thread | | | From | "Kumar, Purushotam" <> | Date | Tue, 17 Mar 2009 15:44:38 +0530 | Subject | RE: [PATCH 1/1] DaVinci: MMC: MMC/SD controller driver for DaVinci/DM6446. |
| |
> > +/* MMCSD Init clock in Hz in opendain mode */ > s/opendain/opendrain
I will make this modification while incorporating review comments.
> > +static irqreturn_t mmc_davinci_irq(int irq, void *dev_id) > > +{ > > + struct mmc_davinci_host *host = (struct mmc_davinci_host *)dev_id; > Unnecessary casting from void *.
I think it always to cast void* pointer and use it.
> > > + > > + ret = -EBUSY; > > + mem_size = r->end - r->start + 1; > > How about using resource_size(...) ? > > > + mem = request_mem_region(r->start, mem_size, pdev->name); > > + if (!mem) > > + goto out;
I could use resource_size.
> > +MODULE_LICENSE("GPL"); > > +MODULE_DESCRIPTION("MMC/SD driver for Davinci MMC controller"); > > Adding MODULE_AUTHOR and MODULE_ALIAS would be great. You can also add > MAINTAINERS entry if you want. I will add MODULE_AUTHOR and MODULE_ALIAS -Purushotam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |