Messages in this thread | | | Date | Tue, 17 Mar 2009 18:23:46 -0700 | Subject | Re: [PATCH 1/2] dmaengine: TXx9 Soc DMA Controller driver | From | Dan Williams <> |
| |
On Tue, Mar 17, 2009 at 5:49 PM, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote: > On Tue, 17 Mar 2009 10:02:14 -0700, Dan Williams <dan.j.williams@intel.com> wrote: > BTW, there are another holes in dma_async_device_register. If > idr_pre_get or idr_get_new was failed, idr_ref will not be freed.
Thanks for these fixlets, I appreciate it.
Now, back to the issue at hand. Does your driver still need direct control over chan->chan_id, or can it now rely on the fact that dma_async_device_register() will fail if a channel is not initialized? Or, just use some platform_data to identify the channel in the same manner as atmel-mci?
Regards, Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |