Messages in this thread | | | Date | Tue, 17 Mar 2009 17:59:22 -0400 (EDT) | From | Steven Rostedt <> | Subject | Re: [PATCH] tracing/ftrace: stop {irqs,preempt}soff tracers when tracing is stopped |
| |
On Tue, 17 Mar 2009, Frederic Weisbecker wrote: > > > + /* > > > + * Stop the tracer to avoid a warning subsequent > > > + * to buffer flipping failure because tracing_stop() > > > + * disables the tr and max buffers, making flipping impossible > > > + * in case of parallels max preempt off latencies. > > > + */ > > > + trace->stop(tr); > > > /* stop the tracing. */ > > > tracing_stop(); > > > > I'm actually thinking that tracing_stop() should call the current tracer > > "stop" function. > > > > -- Steve > > > Indeed, it could be better. > But I think of a combination of stop() callback call plus > ring buffer disabled because I'm not sure all tracers implement > the stop callback.
Yes, that's what I meant. The tracing_stop should do a few things, and one of them is to call the stop function if it exists.
> > Should I send a v2 based on the above?
Sure.
-- Steve
| |