Messages in this thread | | | Date | Tue, 17 Mar 2009 14:39:49 -0400 (EDT) | From | Joe Malicki <> | Subject | Re: [PATCH] CRED: Fix check_unsafe_exec() |
| |
----- "Hugh Dickins" <hugh@veritas.com> wrote:
> On Thu, 12 Mar 2009, David Howells wrote: > > Hugh Dickins <hugh@veritas.com> wrote: > > > > > We do. See the original thread. It's here at > > > http://lkml.org/lkml/2009/2/26/233 > > > and appended below for convenience. We do know that patch did > not > > > fix Joe's problem, and we don't yet know whether addressing the > > > files->count issue will actually fix it, but I'm hopeful. > > > > Looks reasonable. > > Thanks for taking a look. > > Yes, I'm inclined to go with that, and removing the files->count > check from exec.c. Joe, did you manage to try your testing with > my original patch plus that files->count check removed from 2.6.28's > unsafe_exec()?
Sorry for not responding earlier.
I still got one failure with this new patch. I added some printks to illuminate exactly why it's failing when it fails to setuid, but of course, since adding the printks I haven't reproduced yet. Very weird...
Thanks, Joe
> Since Joe's bug has been around forever (if it is what we think it > is), I'm disinclined to rush the fix - something nice to add to > -stable, rather than needing to squeeze into 2.6.29. > > Hugh >
| |