Messages in this thread | | | Subject | Re: [PATCH -tip] cpuacct: Make cpuacct hierarchy walk in cpuacct_charge() safe when rcupreempt is used. | From | Peter Zijlstra <> | Date | Tue, 17 Mar 2009 15:04:46 +0100 |
| |
On Tue, 2009-03-17 at 19:29 +0530, Balbir Singh wrote: > * Peter Zijlstra <a.p.zijlstra@chello.nl> [2009-03-17 14:26:01]: > > > On Tue, 2009-03-17 at 18:42 +0530, Balbir Singh wrote: > > > > > I'd like to get the patches in -tip and see the results, I would > > > recommend using percpu_counter_sum() while reading the data as an > > > enhancement to this patch. If user space does not overwhelm with a lot > > > of reads, sum would work out better. > > > > You trust userspace? I'd rather not. > > > > Fair enough.. A badly written application monitor can frequently read > this data and cause horrible performance issues. On the other hand > large number of CPUs can make the lag even worse. Is it time yet for > percpu_counter batch numbers? I've tested this patch and the results > were not badly off the mark.
I'd rather err on the side of caution here, you might get some crazy folks depending on it and then expecting us to maintain it.
| |