lkml.org 
[lkml]   [2009]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ipu_idmac: code clean-up and robustness improvements
From
On Fri, Mar 13, 2009 at 12:41 AM, Guennadi Liakhovetski <lg@denx.de> wrote:
> General code clean-up: remove superfluous semicolons, update comments.
> Robustness improvements: add DMA error handling to the ISR, move common code
> fragments to functions, fix scatter-gather element queuing in the ISR, survive
> channel freeing and re-allocation in a quick succession.
>
> Signed-off-by: Guennadi Liakhovetski <lg@denx.de>
> ---
>
> Dan, I've been using this patch for a while, without any need for a
> change, so, it should be fine to go upstream.
>

Are you sure that we will never want to bisect in between these
several topics? I would feel more comfortable with at least the fixes
separated from the code refactoring/pure additions.

Thanks,
Dan


\
 
 \ /
  Last update: 2009-03-16 23:01    [W:0.078 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site