Messages in this thread | | | Date | Mon, 16 Mar 2009 22:30:36 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 4/5] lis3: solve dependency between core and ACPI |
| |
Hi!
> > > > This solves the dependency between lis3lv02d.[ch] and ACPI specific > > > > methods. It introduces a ->bus_priv pointer to the device struct which > > > > is casted to 'struct acpi_device' in the ACIP layer. Changed hp_accel.c > > > > accordingly. > > > > > > > > This also moves the read_8() and read_16() routines from hp_accel.c to > > > > lis3lv02d.c as they are not specific to ACPI. > > > Hello, > > > I've tried the patch series on my laptop. This particular patch burst > > > the driver... need some work :-) The values are not read correctly and > > > the IRQ is not detected. See down in the code... > > > > Ok, obvious fixes. I'll post a new set of the three topmost patches - > > could you test them again, please? > > Could anyone test that on hardware which has a lis3 chip? I'd like to > avoid missing the next merge window for this :)
I no longer have the hardware, Vlado has some. As does HP :-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |