lkml.org 
[lkml]   [2009]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[Patch] relay: fix signedness in subbuf_splice_actor()
From
Date
From: Martin Peschke <mpeschke@linux.vnet.ibm.com>

The variable ret is used as a signed value.
Found by a statical code analysis tool.

Signed-off-by: Martin Peschke <mpeschke@linux.vnet.ibm.com>

---
kernel/relay.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- a/kernel/relay.c
+++ b/kernel/relay.c
@@ -1227,7 +1227,8 @@ static int subbuf_splice_actor(struct fi
unsigned int flags,
int *nonpad_ret)
{
- unsigned int pidx, poff, total_len, subbuf_pages, nr_pages, ret;
+ unsigned int pidx, poff, total_len, subbuf_pages, nr_pages;
+ int ret;
struct rchan_buf *rbuf = in->private_data;
unsigned int subbuf_size = rbuf->chan->subbuf_size;
uint64_t pos = (uint64_t) *ppos;



\
 
 \ /
  Last update: 2009-03-16 12:29    [W:0.077 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site