Messages in this thread | | | Date | Sun, 15 Mar 2009 12:52:00 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH 1/1] Char: moxa, fix refcounting in moxa_poll_port |
| |
Restoring CCs.
On 15.3.2009 11:55, Alan Cox wrote: > On Sun, 15 Mar 2009 10:36:08 +0100 > Jiri Slaby<jirislaby@gmail.com> wrote: > >> There is missing tty_kref_put on some paths in moxa_poll_port, >> although the reference is always taken. Fix it. >> >> Signed-off-by: Jiri Slaby<jirislaby@gmail.com> >> Reported-by: Jan 'Yenya' Kasprzak<kas@fi.muni.cz> >> Cc: Alan Cox<alan@lxorguk.ukuu.org.uk> > > Acked-by: Alan Cox<alan@lxorguk.ukuu.org.uk>
BTW the same sha, the change in isicom_shutdown_port doesn't seem to be quite right too. Well, the change itself is, but not in the code context. The tty is used even after tty_port_tty_set(NULL). This is wrong, isn't it?
| |