Messages in this thread | | | Date | Sat, 14 Mar 2009 17:58:40 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH -tip] x86: trampoline.c cleanup |
| |
On Sat, 14 Mar 2009, Jaswinder Singh Rajput wrote: > Hello Thomas, > > On Sat, 2009-03-14 at 17:20 +0100, Thomas Gleixner wrote: > > On Sat, 14 Mar 2009, Jaswinder Singh Rajput wrote: > > > > > Subject: [PATCH] x86: trampoline.c cleanup > > > > > > Impact: cleanup > > > > > > - fix style problems > > > > Err. This patch is a style problem itself. > > > > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> > > > --- > > > arch/x86/kernel/trampoline.c | 3 ++- > > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > > > diff --git a/arch/x86/kernel/trampoline.c b/arch/x86/kernel/trampoline.c > > > index 808031a..e3b1f2e 100644 > > > --- a/arch/x86/kernel/trampoline.c > > > +++ b/arch/x86/kernel/trampoline.c > > > @@ -15,7 +15,7 @@ void __init reserve_trampoline_memory(void) > > > * trampoline before removing it. (see the GDT stuff) > > > */ > > > reserve_early(PAGE_SIZE, PAGE_SIZE + PAGE_SIZE, "EX TRAMPOLINE"); > > > -#endif > > > +#endif /* CONFIG_X86_32 */ > > > > There is no need for this useless comment. The #ifdef is 5 lines > > above. Such comments are only helpful in large nested sections. > > > > Ahh, So > > if (ifdef < 5) > Rule #1 > else > Rule #2
Sigh. I asked for applying common sense not for creating another stupid rule.
Thanks,
tglx
| |