lkml.org 
[lkml]   [2009]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch 2/2] tracepoints for softirq entry/exit - tracepoints
* Jason Baron (jbaron@redhat.com) wrote:
>
> introduce softirq entry/exit tracepoints. These are useful for
> augmenting existing tracers, and to figure out softirq frequencies and
> timings.
>
> Signed-off-by: Jason Baron <jbaron@redhat.com>
>
> ---
>
> include/trace/irq_event_types.h | 12 ++++++++++++
> kernel/softirq.c | 7 ++++++-
> 2 files changed, 18 insertions(+), 1 deletions(-)
>
>
> diff --git a/include/trace/irq_event_types.h b/include/trace/irq_event_types.h
> index 214bb92..38b4bdd 100644
> --- a/include/trace/irq_event_types.h
> +++ b/include/trace/irq_event_types.h
> @@ -40,4 +40,16 @@ TRACE_EVENT(irq_handler_exit,
> __entry->irq, __entry->ret ? "handled" : "unhandled")
> );
>
> +TRACE_FORMAT(irq_softirq_entry,
> + TP_PROTO(struct softirq_action *h, struct softirq_action *vec),
> + TP_ARGS(h, vec),
> + TP_FMT("softirq=%d action=%s", h - vec, softirq_to_name[h-vec])
> + );
> +
> +TRACE_FORMAT(irq_softirq_exit,
> + TP_PROTO(struct softirq_action *h, struct softirq_action *vec),
> + TP_ARGS(h, vec),
> + TP_FMT("softirq=%d action=%s", h - vec, softirq_to_name[h-vec])

The softirq tracepoints are a good idea indeed (I have similar ones in
the LTTng tree). My main concern is about the fact that you output the
softirq name in plain text to the trace buffers. I would rather prefer
to save only the softirq (h-vec) into the trace and dump the mapping
(h-vec) to name only once, so we can save precious trace bytes.

Mathieu

> + );
> +
> #undef TRACE_SYSTEM
> diff --git a/kernel/softirq.c b/kernel/softirq.c
> index ba1511f..c378d53 100644
> --- a/kernel/softirq.c
> +++ b/kernel/softirq.c
> @@ -24,6 +24,7 @@
> #include <linux/ftrace.h>
> #include <linux/smp.h>
> #include <linux/tick.h>
> +#include <trace/irq.h>
>
> #include <asm/irq.h>
> /*
> @@ -186,6 +187,9 @@ EXPORT_SYMBOL(local_bh_enable_ip);
> */
> #define MAX_SOFTIRQ_RESTART 10
>
> +DEFINE_TRACE(irq_softirq_entry);
> +DEFINE_TRACE(irq_softirq_exit);
> +
> asmlinkage void __do_softirq(void)
> {
> struct softirq_action *h;
> @@ -212,8 +216,9 @@ restart:
> if (pending & 1) {
> int prev_count = preempt_count();
>
> + trace_irq_softirq_entry(h, softirq_vec);
> h->action(h);
> -
> + trace_irq_softirq_exit(h, softirq_vec);
> if (unlikely(prev_count != preempt_count())) {
> printk(KERN_ERR "huh, entered softirq %td %s %p"
> "with preempt_count %08x,"
>

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68


\
 
 \ /
  Last update: 2009-03-14 03:59    [W:0.147 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site