lkml.org 
[lkml]   [2009]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 85/96] Fix no_timer_check on x86_64
    2.6.27-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Alexander Graf <agraf@suse.de>

    fixed upstream in 2.6.28 in merge of ioapic*.c for x86

    In io_apic_32.c the logic of no_timer_check is "always make timer_irq_works
    return 1".

    Io_apic_64.c on the other hand checks for
    if (!no_timer_check && timer_irq_works())
    basically meaning "make timer_irq_works fail" in the crucial first check.

    Now, in order to not move too much code, we can just reverse the logic here
    and should be fine off, basically rendering no_timer_check useful again.

    This issue seems to be resolved as of 2.6.28 by the merge of io_apic*.c,
    but still exists for at least 2.6.27.

    Signed-off-by: Alexander Graf <agraf@suse.de>
    Acked-by: Marcelo Tosatti <mtosatti@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>


    ---
    arch/x86/kernel/io_apic_64.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/kernel/io_apic_64.c
    +++ b/arch/x86/kernel/io_apic_64.c
    @@ -1729,7 +1729,7 @@ static inline void __init check_timer(vo
    setup_timer_IRQ0_pin(apic1, pin1, cfg->vector);
    }
    unmask_IO_APIC_irq(0);
    - if (!no_timer_check && timer_irq_works()) {
    + if (no_timer_check || timer_irq_works()) {
    if (nmi_watchdog == NMI_IO_APIC) {
    setup_nmi();
    enable_8259A_irq(0);



    \
     
     \ /
      Last update: 2009-03-14 01:53    [W:4.114 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site