lkml.org 
[lkml]   [2009]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 56/96] proc: fix kflags to uflags copying in /proc/kpageflags
    2.6.27-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Wu Fengguang <fengguang.wu@intel.com>

    commit ad3bdefe877afb47480418fdb05ecd42842de65e upstream.

    Fix kpf_copy_bit(src,dst) to be kpf_copy_bit(dst,src) to match the
    actual call patterns, e.g. kpf_copy_bit(kflags, KPF_LOCKED, PG_locked).

    This misplacement of src/dst only affected reporting of PG_writeback,
    PG_reclaim and PG_buddy. For others kflags==uflags so not affected.

    Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
    Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/proc/proc_misc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/proc/proc_misc.c
    +++ b/fs/proc/proc_misc.c
    @@ -797,7 +797,7 @@ static struct file_operations proc_kpage
    #define KPF_RECLAIM 9
    #define KPF_BUDDY 10

    -#define kpf_copy_bit(flags, srcpos, dstpos) (((flags >> srcpos) & 1) << dstpos)
    +#define kpf_copy_bit(flags, dstpos, srcpos) (((flags >> srcpos) & 1) << dstpos)

    static ssize_t kpageflags_read(struct file *file, char __user *buf,
    size_t count, loff_t *ppos)



    \
     
     \ /
      Last update: 2009-03-14 01:43    [W:0.020 / U:63.500 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site