lkml.org 
[lkml]   [2009]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86: relocs is only used with 32bit
    Eric W. Biederman wrote:
    >>
    >> In general I prefer minimizing the conditional sections rather than
    >> maximizing them. If nothing else, it catches errors earlier that way,
    >> and makes it easier to eventually eliminate them entirely.
    >
    > Makes sense. Although in this case that rule appears like it
    > can't even execute on x86_64.
    >

    That's fine. This is the same reason why it's better to have
    if () { ... } than #ifdef as long as the condition can be statically
    determined -- at least this way make will complain about a syntax error.

    -hpa


    \
     
     \ /
      Last update: 2009-03-14 00:37    [W:0.020 / U:26.804 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site