lkml.org 
[lkml]   [2009]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/5] x86, bts: detect size of DS fields

Applied your patches to tip:tracing/hw-branch-tracer, thanks
Markus!

I did a small cleanup patch - see it in this thread.

One detail i noticed:

static DEFINE_PER_CPU(struct ds_configuration, ds_cfg_array);

That PER_CPU indirection should be removed - it's enough to have
system-wide configuration settings. We dont generally support
assymetric CPU capabilities in the same system, and the per_cpu
indirection here slows the code down and obfuscates it.

Thanks,

Ingo


\
 
 \ /
  Last update: 2009-03-13 12:07    [from the cache]
©2003-2011 Jasper Spaans