Messages in this thread | | | Date | Thu, 12 Mar 2009 21:38:31 +0000 | From | Alan Cox <> | Subject | Re: [Xen-devel] Re: [PATCH] IRQ handling race and spurious IIR read in serial/8250.c |
| |
> 1. It is definitely correct and does not introduce any new bugs.
Right ;)
> 2. It makes the existing bug definitely go away. That is, after my > patch is applied the code drives the UART correctly - that is, > according to the specification and in a manner guaranteed to be
The UART hardware and specifications diverge - often quite spectacularly.
> 4. Any fix which does not involve completely removing UART_BUG_TXEN > will need my change.
Or the locking fix
It was described as a band aid so I treated it as such. Regardless of the right thing to do long term its not a 2.6.29 candidate at this point but certainly something that wants looking into in 2.6.30
| |