Messages in this thread | | | Date | Thu, 12 Mar 2009 13:19:28 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] eliminate spurious pointless WARN_ON()s |
| |
* Jan Beulich <jbeulich@novell.com> wrote:
> Namely during early boot, the panic() or BUG() paths may end > up in smp_call_function_*() with just a single online CPU. In > that situation the warnings generated are not only > meaningless, but also result in relevant output being > cluttered. > > Therefore, defer the WARN_ON() checks until after the > (unaffected from the problem that is being attempted to be > detected here) cases have been handled.
Makes sense probably - but please send a patch against -tip as we've got quite many changes queued up in that area and your patch does not apply cleanly:
patching file kernel/smp.c Hunk #1 FAILED at 222. Hunk #2 FAILED at 229. Hunk #3 FAILED at 325. Hunk #4 FAILED at 344. 4 out of 4 hunks FAILED -- rejects in file kernel/smp.c
Thanks,
Ingo
| |