Messages in this thread | | | Date | Wed, 11 Mar 2009 21:28:48 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86: relocs is only used with 32bit |
| |
Hi Yinghai,
In general I prefer minimizing the conditional sections rather than maximizing them. If nothing else, it catches errors earlier that way, and makes it easier to eventually eliminate them entirely.
-hpa
Yinghai Lu wrote: > Impact: cleanup > > those lines is not needed for 64bit > > Signed-off-by: Yinghai Lu <yinghai@kernel.org> > > --- > arch/x86/boot/compressed/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > Index: linux-2.6/arch/x86/boot/compressed/Makefile > =================================================================== > --- linux-2.6.orig/arch/x86/boot/compressed/Makefile > +++ linux-2.6/arch/x86/boot/compressed/Makefile > @@ -26,6 +26,7 @@ OBJCOPYFLAGS_vmlinux.bin := -R .comment > $(obj)/vmlinux.bin: vmlinux FORCE > $(call if_changed,objcopy) > > +ifeq ($(CONFIG_X86_32),y) > > targets += vmlinux.bin.all vmlinux.relocs relocs > hostprogs-$(CONFIG_X86_32) += relocs > @@ -42,8 +43,6 @@ quiet_cmd_relocbin = BUILD $@ > $(obj)/vmlinux.bin.all: $(vmlinux.bin.all-y) FORCE > $(call if_changed,relocbin) > > -ifeq ($(CONFIG_X86_32),y) > - > ifdef CONFIG_RELOCATABLE > $(obj)/vmlinux.bin.gz: $(obj)/vmlinux.bin.all FORCE > $(call if_changed,gzip)
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |