lkml.org 
[lkml]   [2009]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] [net/irda]: new Blackfin on-chip SIR IrDA driver
From
On Wed, Mar 11, 2009 at 3:57 PM, Mike Frysinger <vapier.adi@gmail.com> wrote:
> On Wed, Mar 11, 2009 at 03:29,  <graff.yang@gmail.com> wrote:
>> +static int __devinit bfin_sir_probe(struct platform_device *pdev)
>> +{
>> +       struct net_device *dev;
>> +       struct bfin_sir_self *self;
>> +       unsigned int baudrate_mask;
>> +       struct bfin_sir_port *sir_port;
>> +       int err;
>> +
>> +       err = peripheral_request_list(per[pdev->id], DRIVER_NAME);
>
> what if pdev->id is set to 12512 ?

The pdev->id is defined in board files, for example, uart0 should be 0.
>
>> +       switch (max_rate) {
>> +       default:
>> +               printk(KERN_WARNING "bfin_sir: Invalid maximum baud rate, using 9600\n");
>
> dev_warn(&dev->dev,....) ?

Here the netdev has not been registered.

> -mike
>



--
-Graff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-03-11 10:59    [W:0.059 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site