Messages in this thread Patch in this message | | | From | Jiri Slaby <> | Subject | [PATCH 3/5] USB: misc/adutux, fix lock imbalance | Date | Wed, 11 Mar 2009 21:47:38 +0100 |
| |
Don't unlock adutux_mutex when not held.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com> --- drivers/usb/misc/adutux.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index 7b6922e..2035265 100644 --- a/drivers/usb/misc/adutux.c +++ b/drivers/usb/misc/adutux.c @@ -376,7 +376,7 @@ static int adu_release(struct inode *inode, struct file *file) if (dev->open_count <= 0) { dbg(1," %s : device not opened", __func__); retval = -ENODEV; - goto exit; + goto unlock; } adu_release_internal(dev); @@ -385,9 +385,9 @@ static int adu_release(struct inode *inode, struct file *file) if (!dev->open_count) /* ... and we're the last user */ adu_delete(dev); } - -exit: +unlock: mutex_unlock(&adutux_mutex); +exit: dbg(2," %s : leave, return value %d", __func__, retval); return retval; } -- 1.6.2 caught by stanse
| |