lkml.org 
[lkml]   [2009]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [v1 PATCH 3/8] EDAC: AMD8111 driver source file
On Mon,  9 Mar 2009 16:08:12 +0800
Harry Ciao <qingtao.cao@windriver.com> wrote:

> Introduce AMD8111 EDAC driver source file, which makes use of error
> detections on the LPC Bridge Controller and PCI Bridge Controller on
> the AMD8111 HyperTransport I/O Hub.
>
>
> ...
>
> +/* Wrapper functions for accessing PCI configuration space */
> +static int edac_pci_read_dword(struct pci_dev *dev, int reg, u32 *val32)
> +{
> + int ret;
> +
> + ret = pci_read_config_dword(dev, reg, val32);
> + if (ret > 0)
> + printk(KERN_ERR AMD8111_EDAC_MOD_STR
> + " PCI Access Read Error at 0x%x\n", reg);
> +
> + return ret;
> +}
>
> +static void edac_pci_read_byte(struct pci_dev *dev, int reg, u8 *val8)
> +{
> + int ret;
> +
> + ret = pci_read_config_byte(dev, reg, val8);
> + if (ret > 0)
> + printk(KERN_ERR AMD8111_EDAC_MOD_STR
> + " PCI Access Read Error at 0x%x\n", reg);
> +}
> +
> +static void edac_pci_write_dword(struct pci_dev *dev, int reg, u32 val32)
> +{
> + int ret;
> +
> + ret = pci_write_config_dword(dev, reg, val32);
> + if (ret > 0)
> + printk(KERN_ERR AMD8111_EDAC_MOD_STR
> + " PCI Access Write Error at 0x%x\n", reg);
> +}
> +
> +static void edac_pci_write_byte(struct pci_dev *dev, int reg, u8 val8)
> +{
> + int ret;
> +
> + ret = pci_write_config_byte(dev, reg, val8);
> + if (ret > 0)
> + printk(KERN_ERR AMD8111_EDAC_MOD_STR
> + " PCI Access Write Error at 0x%x\n", reg);
> +}


<spends a while trying to work out what the return value of
pci_read_config_dword() means>

<gets frustrated and gives up>

Is it correct that all of these functions treat a +ve return value as
an error?

>
> ...
>


\
 
 \ /
  Last update: 2009-03-10 21:51    [W:0.077 / U:0.180 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site