lkml.org 
[lkml]   [2009]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] checkpatch: Warn on empty commit log bodies
On Sat, Feb 28, 2009 at 07:18:29PM -0500, Theodore Tso wrote:
> On Sun, Mar 01, 2009 at 12:01:38AM +0100, Stefan Richter wrote:
> > > As I have previously said, that is not the case in reality. There
> > > appears to be substantial sentiment among people handling patches that
> > > not having any text in the body of the e-mail makes it harder to handle
> > > patches.
> >
> > It is indeed a problem
> > - if the patch title alone insufficiently describes the patch
> > or
> > - if a patch reviewer believes that it is OK to ignore patch titles.
>
> Worse yet, if we start getting these sorts of entries being returned
> by "git log":
>
> ------------
> ext4: Fix spelling error: successfull
>
> Fix spelling error: successfull
>
> Signed-off-by: "Trivial Patch Submitter" <spelling@nits.org>
> ------------
>
> Just to shut up checkpatch, I'm going to feel the urge to shake a
> checkpatch maintainer warmly by the throat.
>
> Sometimes, all that is needed is:
>
> ------------
> ext4: Fix spelling error: successfull
>
> Signed-off-by: "Trivial Patch Submitter" <spelling@nits.org>
> ------------

Not wanting my throat felt warmly, and as there does not seem to be
a sensible way to detect poor changelogs I am not propsing to make any
change to checkpatch on this one.

-apw


\
 
 \ /
  Last update: 2009-03-10 19:23    [W:0.186 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site