lkml.org 
[lkml]   [2009]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] [net/irda]: new Blackfin on-chip SIR IrDA driver
From
On Tue, Mar 10, 2009 at 07:25, graff yang wrote:
> On Tue, Mar 10, 2009 at 4:03 PM, Mike Frysinger wrote:
>> On Tue, Mar 10, 2009 at 03:29,  <graff.yang@gmail.com> wrote:
>> > +       baudrate_mask = IR_9600;
>> > +
>> > +       switch (max_rate) {
>> > +       case 115200:
>> > +               baudrate_mask |= IR_115200;
>> > +       case 57600:
>> > +               baudrate_mask |= IR_57600;
>> > +       case 38400:
>> > +               baudrate_mask |= IR_38400;
>> > +       case 19200:
>> > +               baudrate_mask |= IR_19200;
>> > +       }
>>
>> what if someone specified max_rate = 1231245 ?
>
> The  initial value of baudrate_mask is IR_9600.

i meant in terms of the user being notified it's a bogus value. what
if they did max_rate=576000 ? clearly they meant 57600, but they hit
"0" too many times ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-03-10 12:33    [from the cache]
©2003-2011 Jasper Spaans