lkml.org 
[lkml]   [2009]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lenovo-sl-laptop : driver for review
On Sat 2009-02-28 11:37:11, Henrique de Moraes Holschuh wrote:
> On Fri, 27 Feb 2009, Pavel Machek wrote:
> > > +module_param(debug_ec, bool, S_IRUGO);
> > > +MODULE_PARM_DESC(debug_ec,
> > > + "Present EC debugging interface in procfs. WARNING: writing to the "
> > > + "EC can hang your system and possibly damage your hardware.");
> >
> > Sounds dangerous and clearly does not belong to /proc. Please drop it.
>
> ThinkPad ACPI also has one. OTOH, we are fairly sure one cannot damage the
> standard ThinkPad hardware through the "IBM thinkpad-style" EC firmware, the
> EC sanity-checks things. I suppose you could cause the box to go away for
> lunch and don't come back until a complete hardware reset, or hit one of the
> crash-the-EC-firmware bugs by accident, though.

Yeah but that interface still does not belong to /proc. Please drop it
from merge version at least.

> > > +/*************************************************************************
> > > + bluetooth sysfs - copied nearly verbatim from thinkpad_acpi.c
> > > + *************************************************************************/
> >
> > That's quite a lot of code for verbatim copy; create shared helper?
>
> Yeah, I am game. But let's do it later on and not delay anything because of
> it, please. I will start breaking thinkpad-acpi into multiple source files,
> and after that is done (should take a while, thinkpad-acpi is a big module
> with a LOT of subdriver interdependencies) we can look for the best way to
> reduce code duplication.

Well, this monolith is quite long/hard to review. IMO it should be
split to make review easy.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2009-03-10 12:27    [W:0.049 / U:1.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site