lkml.org 
[lkml]   [2009]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv2] isdn: reduce stack size of mISDN_dsp
    On Sun, Mar 01, 2009 at 06:10:24PM +0100, Frank Seidel wrote:
    > From: Frank Seidel <frank@f-seidel.de>
    >
    > Reduce stack size memory footprint of mISDN_dsp.
    > (From 1468 bytes for dsp_cmx_send on i386 down
    > to 44).

    Looks safer and has the same function as before, but
    I think we should work on a better solution later, which
    use one buffer per instance and allocate it on creation time.
    Andreas, what do you think ?

    >
    > Signed-off-by: Frank Seidel <frank@f-seidel.de>
    > ---
    > drivers/isdn/mISDN/dsp_cmx.c | 12 +++++++++++-
    > 1 file changed, 11 insertions(+), 1 deletion(-)
    >
    > --- a/drivers/isdn/mISDN/dsp_cmx.c
    > +++ b/drivers/isdn/mISDN/dsp_cmx.c
    > @@ -1592,13 +1592,21 @@ dsp_cmx_send(void *arg)
    > struct dsp_conf_member *member;
    > struct dsp *dsp;
    > int mustmix, members;
    > - s32 mixbuffer[MAX_POLL+100], *c;
    > + s32 *mixbuffer;
    > + s32 *c;
    > u8 *p, *q;
    > int r, rr;
    > int jittercheck = 0, delay, i;
    > u_long flags;
    > u16 length, count;
    >
    > + mixbuffer = kmalloc(sizeof(*mixbuffer) * (MAX_POLL + 100), GFP_KERNEL);
    > + if (!mixbuffer) {
    > + printk(KERN_ERR "mISDN_dsp: cannot allocate buffer(%s)\n",
    > + __func__);
    > + return;
    > + }
    > +
    > /* lock */
    > spin_lock_irqsave(&dsp_lock, flags);
    >
    > @@ -1811,6 +1819,8 @@ dsp_cmx_send(void *arg)
    >
    > /* unlock */
    > spin_unlock_irqrestore(&dsp_lock, flags);
    > +
    > + kfree(mixbuffer);
    > }
    >
    > /*

    --
    Karsten Keil


    \
     
     \ /
      Last update: 2009-03-01 20:57    [W:0.021 / U:181.204 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site