lkml.org 
[lkml]   [2009]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [build bug] uvc_status_cleanup(): undefined reference to `input_unregister_device'
Date
Hi Ingo,

On Sunday 08 February 2009 15:58:35 Ingo Molnar wrote:
> Hi, havent seen this reported on lkml yet.
>
> -tip testing found that certain (user-reachable) Kconfig combinations
> can cause this build failure on latest mainline:
>
> drivers/built-in.o: In function `uvc_status_cleanup':
> (.text+0x221cca): undefined reference to `input_unregister_device'
> drivers/built-in.o: In function `uvc_status_init':
> (.text+0x221d4c): undefined reference to `input_allocate_device'
> drivers/built-in.o: In function `uvc_status_init':
> (.text+0x221db3): undefined reference to `input_free_device'
> drivers/built-in.o: In function `uvc_status_init':
> (.text+0x221ec6): undefined reference to `input_register_device'
> drivers/built-in.o: In function `uvc_status_complete':
> uvc_status.c:(.text+0x2222ec): undefined reference to `input_event'
>
> triggered on v2.6.29-rc3-697-gae1a25d. The problem is this combination:
>
> CONFIG_INPUT=m
> CONFIG_USB_VIDEO_CLASS=y
> CONFIG_USB_VIDEO_CLASS_INPUT_EVDEV=y

Thanks for the report. The following patch should fix the issue.

diff --git a/drivers/media/video/uvc/Kconfig b/drivers/media/video/uvc/Kconfig
index c2d9760..0dbe7b9 100644
--- a/drivers/media/video/uvc/Kconfig
+++ b/drivers/media/video/uvc/Kconfig
@@ -9,7 +9,7 @@ config USB_VIDEO_CLASS
config USB_VIDEO_CLASS_INPUT_EVDEV
bool "UVC input events device support"
default y
- depends on USB_VIDEO_CLASS && INPUT
+ depends on USB_VIDEO_CLASS && (INPUT = y || INPUT = USB_VIDEO_CLASS)
---help---
This option makes USB Video Class devices register an input device
to report button events.
I'm not completely satisfied with this though, as the
USB_VIDEO_CLASS_INPUT_EVDEV completely disappears from the configuration menu
if INPUT is set to 'm' and USB_VIDEO_CLASS to 'y'. Being no Kconfig guru, I'd
appreciate if someone could help me to find a nicer fix (if that's possible at
all).

Laurent Pinchart



\
 
 \ /
  Last update: 2009-02-10 01:43    [W:1.745 / U:1.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site