lkml.org 
[lkml]   [2009]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Linux-fbdev-devel] [PATCH 13/15] amba-clcd: fix cmap memory leaks
On Mon, 9 Feb 2009 21:16:14 +0100
Krzysztof Helt <krzysztof.h1@wp.pl> wrote:

> On Sat, 7 Feb 2009 12:18:48 -0500
> Andres Salomon <dilinger@queued.net> wrote:
>
> >
> > - fix cmap leak in removal path
> > - fix cmap leak when register_framebuffer fails
> >
> > Signed-off-by: Andres Salomon <dilinger@debian.org>
> > ---
>
> Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>
>
> One comment (see below).
>
[...]
> > @@ -485,6 +489,8 @@ static int clcdfb_remove(struct amba_device
> > *dev)
> > clcdfb_disable(fb);
> > unregister_framebuffer(&fb->fb);
> > + if (fb->fb.cmap.len)
> > + fb_dealloc_cmap(&fb->fb.cmap);
>
> Is this if() needed? Is this function called twice (or more) or
> can it be called without the cmap allocated?


It was added as a precaution due to the fb->board->remove callbacks,
but I think I misunderstood the code. So my official answer is "I'm not
sure." :)





>
> > iounmap(fb->regs);
> > clk_put(fb->clk);
> >
> > --
> > 1.5.6.5
> >


\
 
 \ /
  Last update: 2009-02-09 22:59    [W:0.039 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site